commit | 2545cc4292cd8343302b111104201f60a1701a63 | [log] [tgz] |
---|---|---|
author | Moe Ahmadi <mahmadi@chromium.org> | Tue Dec 11 12:31:31 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 11 12:31:31 2018 |
tree | 54b82cbac4e8860bec91e262ccb211608fbd70ee | |
parent | 5aeb932e04f7f94225f5eb804967f3985ed3de9d [diff] |
[iOS][Translate] Moves LanguageSelectionHnadler out of infobarcoordinator Instead of passing the id<LanguageSelectionHandler> to the ChromeIOSTranslateClient during construction which is prone to error due to dependency on the order in which ChromeIOSTranslateClient and the InfobarCoordinator are initialized, this CL modifies the LanguageSelectionCoordinator to observe the WebStateList and set/unset the id<LanguageSelectionHandler> on instances of ChromeIOSTranslateClient when appropriate. This fixes a DCHECK during ChromeIOSTranslateClient construction and helps make the feature more self-contained as the InfobarCoordinator/Mediator no longer needs to know about the languageSelectionHandler. TBR=rohitrao@ Bug: 912502 Change-Id: Id3769f10a0ed638821afdd9578bd263700768299 Reviewed-on: https://chromium-review.googlesource.com/c/1366467 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615500}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .