Change gpu/ipc:command_buffer_sources to static_library
A 900 KB size regression popped up at R431519. This CL
fixes it by changing a source_set to a static_library. The effect is to
reduce the size of chrome.dll significantly, fixing the regression:
chrome.dll
.text: -711776 bytes change
.rdata: -160752 bytes change
.data: -10848 bytes change
.reloc: -33736 bytes change
Total change: -917112 bytes
A custom version of dia2dump.exe was used to find global variables that
appeared in chrome.dll when the regression happened. One of the globals
was cmaa_frag_s2_. This was declared in gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
so a verbose link of chrome.dll was done and a script (linker_verbose_tracking.py)
was used to find out what was causing this .obj file to be pulled in.
It pointed to in_process_command_buffer.obj, and that led to the fix.
The fix was tested on a release build, but not an official build, so it
is possible that the savings will not apply to official builds. This
will be monitored.
BUG=664481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2556603002
Cr-Commit-Position: refs/heads/master@{#436731}
1 file changed
