| commit | 255bf2d65ada1a77bc23a111267bef0a94e8c47f | [log] [tgz] |
|---|---|---|
| author | Nico Weber <thakis@chromium.org> | Fri Sep 15 22:57:07 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 20 11:25:51 2017 |
| tree | 63be999ff16cb3ce6c88895b839c5927247d3d9c | |
| parent | 5c2ffc9c3cb6e5de1c739111c5eb3d72eea50345 [diff] |
v8: Fix most -Wunreachable-code warnings. Do this by deleting code after calls to V8_Fatal() (either through UNREACHABLE() or FATAL()). Comments suggest that the returns there were needed to make a compiler happy, but all compilers seem to be happy with this change too. My guess is that either https://codereview.chromium.org/1393023003 which marked V8_Fatal() as noreturn, or https://chromium-review.googlesource.com/#/c/544845/ which switched to the C++11 spelling of noreturn, fixed the warnings that the explicit code after V8_Fatal() was supposed to silence. There's one more warning in src/compiler/machine-graph-verifier.cc, but fixing that changes behavior. I asked about that one in https://codereview.chromium.org/2573573004/#msg27 instead. Bug: chromium:346399 Change-Id: Ie9519d5432bdeaaf382e8390d8254d3b79e622e4 Reviewed-on: https://chromium-review.googlesource.com/669803 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48092}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.