Only whitelist messages.json files in _locales for content verification

Only whitelist messages.json files in _locales for content verification

The messages.json files used for i18n/l10n get transcoded during the
extension install process, so we need to avoid doing content
verification checks on them because we expect their contents to be
modified. The code we had for testing whether a path should be skipped
because of this was incorrect, skipping more files than it should.

BUG=672008

[asargent_no_longer_on_chrome, 2016-12-14 00:36:15]

The CQ bit was checked by asargent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 00:36:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:25:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[asargent_no_longer_on_chrome, 2016-12-14 21:31:50]

The CQ bit was checked by asargent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 21:32:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 22:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 22:22:07]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[asargent_no_longer_on_chrome, 2016-12-15 00:16:38]

Description was changed from

==========
Only whitelist messages.json files in _locales for content verification

The messages.json files used for i18n/l10n get transcoded during the
extension install process, so we need to avoid doing content
verification checks on them because we expect their contents to be
modified. The code we had for testing whether a path should be skipped
because of this was incorrect, letting through more files than it
should.

BUG=672008
==========

to

==========
Only whitelist messages.json files in _locales for content verification

The messages.json files used for i18n/l10n get transcoded during the
extension install process, so we need to avoid doing content
verification checks on them because we expect their contents to be
modified. The code we had for testing whether a path should be skipped
because of this was incorrect, skipping more files than it should.

BUG=672008
==========

[asargent_no_longer_on_chrome, 2016-12-15 00:20:58]

The CQ bit was checked by asargent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 00:21:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asargent_no_longer_on_chrome, 2016-12-15 00:25:45]

asargent@chromium.org changed reviewers:
+ lazyboy@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:54:44]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[asargent_no_longer_on_chrome, 2016-12-15 01:09:49]

The CQ bit was checked by asargent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 01:10:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:16:07]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[lazyboy, 2016-12-15 23:48:22]

lgtm.
It seems win_x64 bot is failing.

[elawrence, 2016-12-16 15:59:15]

On 2016/12/15 00:25:46, Antony Sargent wrote:

In the bug, one thing he mentioned was "Similar approach could be used by
extension for evaluation code from messages.json". This patch doesn't address
that concern, does it?

[asargent_no_longer_on_chrome, 2016-12-16 18:46:56]

On 2016/12/16 15:59:15, elawrence wrote:
> On 2016/12/15 00:25:46, Antony Sargent wrote:
> 
> In the bug, one thing he mentioned was "Similar approach could be used by
> extension for evaluation code from messages.json". This patch doesn't address
> that concern, does it?

I'll explain in more detail on the bug.

[lazyboy, 2017-04-26 01:14:38]

@asargent, I've landed this change at:
https://codereview.chromium.org/2834873002/
You can close this one now!

[asargent_no_longer_on_chrome, 2017-04-26 16:47:44]

Ok!