[Profiles] Don't treat GAIA names differently than regular profile names.
This also half-enables the ability to use the Gaia profile pictures as the profile
avatar on the main truck if you had previously used the
--new-profile-management or --gaia-profile-info flags before. (Because
the chrome://settings doesn't enable setting it outside the flag).
There was special, ancient logic that treated profiles using a Gaia names
as "special", which didn't mix well with syncing of the profile name. Basically,
you could either use a synced profile name, or a Gaia name, but not both
(i.e. download the synced name and then be able to rename the profile back
to its Gaia name).
I think this fixes it. and shouldn't really break a lot of other things, as the two
functions that I've deleted weren't really used anywhere.
BUG=352090
TEST=Be able to rename a local profile. Be able to sign in to a profile, and if
this is the first time you're doing it, the profile name should be the user's Gaia
first name. Be able to rename this profile to a custom name, and back to the
Gaia name. Finally, if you're signing in with this account on a different profile,
the name that you last left off should be the one that is synced/used.
Review URL: https://codereview.chromium.org/196473015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259161 0039d316-1c4b-4281-b951-d872f2087c98
7 files changed
