commit | 25ece65f0f4130b0d34236e8715ecff5beaa4a82 | [log] [tgz] |
---|---|---|
author | Tessa Nijssen <tnijssen@google.com> | Thu Aug 16 20:08:25 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 16 20:08:25 2018 |
tree | 5559d49fd8e60fc6ef10fb5b52c614e64f196f0e | |
parent | e015a2536d02e21d516c544d85615e844b391cce [diff] |
[Mac] Reset Touch Bar Text Suggestions on Main Thread Previously, -requestSuggestions would asynchronously reset |suggestions_| on a thread separate from the main thread. This caused issues were -createCandidateListItem could try to read |suggestions_| while it was being reset, causing zombie dealloc crashes. Now, -requestSuggestions resets |suggestions_| on the main thread, so the previous crashes cannot happen. Bug: 717553 Change-Id: I016b054673fe8d2bb9bcb6c644c90b3c83eef311 Reviewed-on: https://chromium-review.googlesource.com/1175223 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#583786}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .