Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2622703002: Move five files from non-NaCl to NaCl in net.gypi. (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
Reviewers:
asanka
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move five files from non-NaCl to NaCl in net.gypi. This is necessary to fix linker errors at https://crrev.com/2611173004 up to Patch Set 4, see how trybots pass for Patch Set 6. spdy_header_block.h is included by http_log_util.h, that's why it needs to be moved from net_non_nacl_sources to net_nacl_common_sources. The other files are used by SpdyHeaderBlock, so they have to go too. Review-Url: https://codereview.chromium.org/2622703002 Cr-Commit-Position: refs/heads/master@{#442394} Committed: https://chromium.googlesource.com/chromium/src/+/ec8d2b8827183cc435cafd4dece1b3acc699496b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/net.gypi View 6 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Bence
Asanka: PTAL. Thank you.
3 years, 11 months ago (2017-01-09 21:09:09 UTC) #7
asanka
lgtm
3 years, 11 months ago (2017-01-09 21:29:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622703002/1
3 years, 11 months ago (2017-01-09 22:59:30 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 23:14:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec8d2b8827183cc435cafd4dece1...

Powered by Google App Engine
This is Rietveld 408576698