commit | 26336b9af5abe3580668f2ff0f8f354cb23adf95 | [log] [tgz] |
---|---|---|
author | Xida Chen <xidachen@chromium.org> | Mon Jul 09 00:28:10 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 09 00:28:10 2018 |
tree | 638f191e0630aa88740eb0c2e6aa451730754b14 | |
parent | f8f07de18b6d417a2907c7d886611b09d46d30c5 [diff] |
Reland "Deflake one of TouchActionBrowserTest" This is a reland of c32a3d1ec4331f10e0efbd5d979a833f8e1a57ce The original CL was reverted by a sheriff here: https://chromium-review.googlesource.com/c/chromium/src/+/1113217, the tracking bug is 855979, it suspects that the original CL caused flaky in *san bots. But, the fact is that there is an un-initialized member in touch_event.h, which is the actual cause of the flakiness in *san bots, and that was fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1116788 With the above fix, let's re-land this CL, otherwise this test is still flaky. Original change's description: > Deflake one of TouchActionBrowserTest > > Some of the TouchActionBrowserTests are flaky. I was recently told by > sahel@ that setting speed_in_pixels_s to a very high number will ensure > there is one GSU only and will prevent the flaky. This does work, at > least locally. I have tried the test in this CL locally and it was > flaky without this change. With this change, I have ran this test 50 > times without any failure. > > This CL does that. Right now there are a few tests marked flaky, this > CL enables one of them first. I will monitor the flakiness dashboard > once this CL lands. If this does solve the problem, we will then enable > more tests. > > Bug: 833015 > Change-Id: I539703866094fb526e220c48aaf327836345b950 > Reviewed-on: https://chromium-review.googlesource.com/1101464 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567692} TBR=tdresser@chromium.org Bug: 833015 Change-Id: I8cd5a6cbec5fe4f9f13e619b001455a97935d1ee Reviewed-on: https://chromium-review.googlesource.com/1124699 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573194}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .