Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2642963002: Remove AudioBassDown/Up (dups of AudioBassBoostDown/Up) (Closed)

Created:
3 years, 11 months ago by garykac
Modified:
3 years, 10 months ago
Reviewers:
chongz
CC:
chromium-reviews, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AudioBassDown/Up (dups of AudioBassBoostDown/Up) See https://github.com/w3c/uievents-key/issues/25 BUG= Review-Url: https://codereview.chromium.org/2642963002 Cr-Commit-Position: refs/heads/master@{#448883} Committed: https://chromium.googlesource.com/chromium/src/+/e2d490853157afe8349f8abf9c5d6fc82a01ed31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/events/keycodes/dom/dom_key_data.inc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
garykac
3 years, 11 months ago (2017-01-18 23:47:24 UTC) #4
chongz
LGTM thanks for the patch! BTW do we need a crbug for this?
3 years, 11 months ago (2017-01-19 16:26:29 UTC) #8
garykac
On 2017/01/19 16:26:29, chongz wrote: > LGTM thanks for the patch! BTW do we need ...
3 years, 10 months ago (2017-01-26 01:09:30 UTC) #9
chongz
On 2017/01/26 01:09:30, garykac wrote: > On 2017/01/19 16:26:29, chongz wrote: > > LGTM thanks ...
3 years, 10 months ago (2017-01-26 18:12:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642963002/1
3 years, 10 months ago (2017-02-08 01:13:20 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 03:07:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2d490853157afe8349f8abf9c5d...

Powered by Google App Engine
This is Rietveld 408576698