commit | 26ef5c910fc7e2edb441f1d2b39944195342dee9 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Wed May 30 16:34:14 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 30 16:46:16 2018 |
tree | eb885e02875ca834659b41158e8931e2beaa1b05 | |
parent | 5c49c598477c69e642b4feb44c4dd3e8857cd82c [diff] |
aarch64: Use xzr instead of x31 in the ASM code Officially, register X31 does not exist. The code is zeroing out a location and thus actually needs XZR. LLVM seems to automatically translate X31 into XZR when compiling the code, but GCC (tested 7.3.0) refuses to accept the instruction: ../../third_party/crashpad/crashpad/util/misc/capture_context_linux.S: Assembler messages: ../../third_party/crashpad/crashpad/util/misc/capture_context_linux.S:291: Error: operand 1 must be an integer register -- `str x31,[x0,#0xb0]' Bug: chromium:819294 Change-Id: I85be3923ac56fca6e3ec59d7e22b2223cfc8fa63 Reviewed-on: https://chromium-review.googlesource.com/1078818 Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.