Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2704263002: MacViews/a11y: Implement NativeViewAccessibilityMac. (Closed)

Created:
3 years, 10 months ago by Patti Lor
Modified:
3 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews/a11y: Implement NativeViewAccessibilityMac. Remove Mac-specific code in the base NativeViewAccessibility class and move it to a platform-specific NativeViewAccessibilityMac. BUG=396137 Review-Url: https://codereview.chromium.org/2704263002 Cr-Commit-Position: refs/heads/master@{#451876} Committed: https://chromium.googlesource.com/chromium/src/+/b498cc969599d5dd5587ef56b352e1dde3b3129e

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
M ui/views/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 1 chunk +0 lines, -6 lines 0 comments Download
A ui/views/accessibility/native_view_accessibility_mac.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A ui/views/accessibility/native_view_accessibility_mac.mm View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Patti Lor
Hi Trent, PTAL! Thanks.
3 years, 10 months ago (2017-02-21 01:43:49 UTC) #6
tapted
lgtm % nits https://codereview.chromium.org/2704263002/diff/1/ui/views/accessibility/native_view_accessibility_mac.h File ui/views/accessibility/native_view_accessibility_mac.h (right): https://codereview.chromium.org/2704263002/diff/1/ui/views/accessibility/native_view_accessibility_mac.h#newcode13 ui/views/accessibility/native_view_accessibility_mac.h:13: class NativeViewAccessibilityMac : public NativeViewAccessibility { ...
3 years, 10 months ago (2017-02-21 04:22:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704263002/20001
3 years, 10 months ago (2017-02-21 06:35:00 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/122962)
3 years, 10 months ago (2017-02-21 09:38:09 UTC) #16
Patti Lor
:O forgot to send drafts https://codereview.chromium.org/2704263002/diff/1/ui/views/accessibility/native_view_accessibility_mac.h File ui/views/accessibility/native_view_accessibility_mac.h (right): https://codereview.chromium.org/2704263002/diff/1/ui/views/accessibility/native_view_accessibility_mac.h#newcode13 ui/views/accessibility/native_view_accessibility_mac.h:13: class NativeViewAccessibilityMac : public ...
3 years, 10 months ago (2017-02-21 22:52:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2704263002/20001
3 years, 10 months ago (2017-02-21 22:55:09 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:37:23 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b498cc969599d5dd5587ef56b352...

Powered by Google App Engine
This is Rietveld 408576698