Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2750853008: Remove HpackDecoder2. (Closed)

Created:
3 years, 9 months ago by Bence
Modified:
3 years, 9 months ago
Reviewers:
yasong, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HpackDecoder2. Also remove associated flag FLAGS_chromium_http2_flag_spdy_use_hpack_decoder2. HpackDecoder2 (an adapter to //gfe/http2/hpack/decoder) was superseded by HpackDecoder3, and has not been used in production. This CL lands server change 149561590 by jamessynge. BUG=488484 Review-Url: https://codereview.chromium.org/2750853008 Cr-Commit-Position: refs/heads/master@{#457474} Committed: https://chromium.googlesource.com/chromium/src/+/a136ffb89abdc69dfbebdf1aeb3a1c7ab28d2902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1488 lines) Patch
M net/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 4 chunks +10 lines, -19 lines 0 comments Download
D net/spdy/hpack/hpack_decoder2.h View 1 chunk +0 lines, -147 lines 0 comments Download
D net/spdy/hpack/hpack_decoder2.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D net/spdy/hpack/hpack_decoder2_test.cc View 1 chunk +0 lines, -959 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 3 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bence
yasong: PTAL. Thank you.
3 years, 9 months ago (2017-03-15 19:09:53 UTC) #6
yasong
On 2017/03/15 19:09:53, Bence wrote: > yasong: PTAL. Thank you. LGTM
3 years, 9 months ago (2017-03-15 19:42:10 UTC) #7
Bence
xunjieli: please rubber stamp. Thank you.
3 years, 9 months ago (2017-03-15 23:57:19 UTC) #9
xunjieli
On 2017/03/15 23:57:19, Bence wrote: > xunjieli: please rubber stamp. Thank you. rubber stamp lgtm
3 years, 9 months ago (2017-03-16 16:49:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750853008/1
3 years, 9 months ago (2017-03-16 17:20:11 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:28:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a136ffb89abdc69dfbebdf1aeb3a...

Powered by Google App Engine
This is Rietveld 408576698