Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2753773003: v8bindings: Reverts crrev.com/2606723002 with minimum changes. (Closed)

Created:
3 years, 9 months ago by Yuki
Modified:
3 years, 9 months ago
Reviewers:
haraken, domenic, alexmos, dcheng
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

v8bindings: Reverts crrev.com/2606723002 with minimum changes. Allows named access on window regardless of same/cross origin nor mismatch between browsing context name and browsing context container's name. Since crrev.com/2606723002 caused crbug.com/701489, we revert the CL with minimum changes because the entire revert is hard. BUG=538562, 701489 Review-Url: https://codereview.chromium.org/2753773003 Cr-Commit-Position: refs/heads/master@{#457138} Committed: https://chromium.googlesource.com/chromium/src/+/8633d64a9677342d7d704e24068f4838a2d2c88a

Patch Set 1 #

Patch Set 2 : Updated tests and their expectations. #

Messages

Total messages: 20 (14 generated)
domenic
LGTM, seems like a minimal change that even increases our pass rate in WPT expectations, ...
3 years, 9 months ago (2017-03-15 17:51:01 UTC) #10
alexmos
content/ LGTM
3 years, 9 months ago (2017-03-15 17:58:48 UTC) #12
dcheng
CQing this on yukishiino's behalf so we can merge this.
3 years, 9 months ago (2017-03-15 18:00:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753773003/20001
3 years, 9 months ago (2017-03-15 18:01:19 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8633d64a9677342d7d704e24068f4838a2d2c88a
3 years, 9 months ago (2017-03-15 18:07:28 UTC) #19
haraken
3 years, 9 months ago (2017-03-15 20:08:14 UTC) #20
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698