Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/32746)
3 years, 9 months ago
(2017-03-15 10:41:31 UTC)
#4
LGTM, seems like a minimal change that even increases our pass rate in WPT expectations, ...
3 years, 9 months ago
(2017-03-15 17:51:01 UTC)
#10
LGTM, seems like a minimal change that even increases our pass rate in WPT
expectations, and clearly documents the path forward.
Hopefully implementing the full spec/passing all web platform tests is still web
compatible. But if not we're happy to revise the spec, just let us know.
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489600842135920, "parent_rev": "ebf283a6e622fdd02d0ab9ee2386dfa50ebcc4e3", "commit_rev": "8633d64a9677342d7d704e24068f4838a2d2c88a"}
3 years, 9 months ago
(2017-03-15 18:06:39 UTC)
#17
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489600842135920,
"parent_rev": "ebf283a6e622fdd02d0ab9ee2386dfa50ebcc4e3", "commit_rev":
"8633d64a9677342d7d704e24068f4838a2d2c88a"}
commit-bot: I haz the power
Description was changed from ========== v8bindings: Reverts crrev.com/2606723002 with minimum changes. Allows named access on ...
3 years, 9 months ago
(2017-03-15 18:07:27 UTC)
#18
Message was sent while issue was closed.
Description was changed from
==========
v8bindings: Reverts crrev.com/2606723002 with minimum changes.
Allows named access on window regardless of same/cross origin
nor mismatch between browsing context name and browsing context
container's name.
Since crrev.com/2606723002 caused crbug.com/701489, we revert
the CL with minimum changes because the entire revert is hard.
BUG=538562,701489
==========
to
==========
v8bindings: Reverts crrev.com/2606723002 with minimum changes.
Allows named access on window regardless of same/cross origin
nor mismatch between browsing context name and browsing context
container's name.
Since crrev.com/2606723002 caused crbug.com/701489, we revert
the CL with minimum changes because the entire revert is hard.
BUG=538562,701489
Review-Url: https://codereview.chromium.org/2753773003
Cr-Commit-Position: refs/heads/master@{#457138}
Committed:
https://chromium.googlesource.com/chromium/src/+/8633d64a9677342d7d704e24068f...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8633d64a9677342d7d704e24068f4838a2d2c88a
3 years, 9 months ago
(2017-03-15 18:07:28 UTC)
#19
Issue 2753773003: v8bindings: Reverts crrev.com/2606723002 with minimum changes.
(Closed)
Created 3 years, 9 months ago by Yuki
Modified 3 years, 9 months ago
Reviewers: domenic, alexmos, dcheng
Base URL:
Comments: 0