Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2800053003: v8binding: Makes xss-DENIED-window-name-navigator deterministic. (Closed)

Created:
3 years, 8 months ago by Yuki
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

v8binding: Makes xss-DENIED-window-name-navigator deterministic. Makes the test result of xss-DENIED-window-name-navigator.html deterministic and fixes the flakiness. This CL doesn't yet update LayoutTests/TestExpectations . The first attempt was: https://crrev.com/2673583003 BUG=686470 Review-Url: https://codereview.chromium.org/2800053003 Cr-Commit-Position: refs/heads/master@{#463254} Committed: https://chromium.googlesource.com/chromium/src/+/e6974751597de203bb5a78dc82fa253517338f0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-navigator.html View 1 chunk +47 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-navigator-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/http/tests/security/xss-DENIED-window-name-navigator-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Yuki
Could you review this CL? This was once reverted at https://crrev.com/2673583003 , but I don't ...
3 years, 8 months ago (2017-04-10 11:55:15 UTC) #10
haraken
LGTM
3 years, 8 months ago (2017-04-10 14:08:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800053003/1
3 years, 8 months ago (2017-04-10 14:09:38 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 14:14:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6974751597de203bb5a78dc82fa...

Powered by Google App Engine
This is Rietveld 408576698