Disable flaky tests that are going to be broken by data URL deprecation

Disable flaky tests that are going to be broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. After crrev.com/2702503002 lands, these test will
stop working because they navigate to data URLs. The fix is to change the
data URLs in these tests to HTTP urls, but doing that causes the tests to
fail more often -- they start to fail on Windows. I investigated the
failures and can't see a good way of fixing them
(https://crbug.com/703727#c8) so I'm disabling them in the meanwhile.

BUG=594215
Review-Url: https://codereview.chromium.org/2803813002
Cr-Commit-Position: refs/heads/master@{#462948}
Committed: https://chromium.googlesource.com/chromium/src/+/158cc5cd0ffef904f0449bb4ea59a9f49f049818

[meacer, 2017-04-05 20:28:04]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 20:28:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2017-04-05 20:34:31]

meacer@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[meacer, 2017-04-05 20:34:32]

wjmaclean: Can you PTAL? Thanks.

[commit-bot: I haz the power, 2017-04-05 21:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:16:31]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-04-07 16:40:08]

On 2017/04/05 20:34:32, Mustafa Emre Acer wrote:
> wjmaclean: Can you PTAL? Thanks.

I'm not sure I understand what you mean by

"Changing these tests to navigate to non-data URLs will manifest the flakes on
all platforms"

Could you please reword this?

[meacer, 2017-04-07 17:36:48]

On 2017/04/07 16:40:08, wjmaclean wrote:
> On 2017/04/05 20:34:32, Mustafa Emre Acer wrote:
> > wjmaclean: Can you PTAL? Thanks.
> 
> I'm not sure I understand what you mean by
> 
> "Changing these tests to navigate to non-data URLs will manifest the flakes on
> all platforms"
> 
> Could you please reword this?

Sorry for the vague wording. After crrev.com/2702503002 lands, these test will
stop working because they navigate to data URLs. The fix is to change the data
URLs in these tests to HTTP urls, but doing that causes the tests to fail more
often -- they start to fail on Windows. I investigated the failures and can't
see a good way of fixing them
(https://bugs.chromium.org/p/chromium/issues/detail?id=703727#c8) so I'd like to
disable them in the meanwhile.

[meacer, 2017-04-07 17:37:32]

Description was changed from

==========
Disable flaky tests that are going to be broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. Changing these tests to navigate to non-data URLs
will manifest the flakes on all platforms, so disabling them until the
flakes are fixed.

BUG=594215
==========

to

==========
Disable flaky tests that are going to be broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. After crrev.com/2702503002 lands, these test will
stop working because they navigate to data URLs. The fix is to change the
data URLs in these tests to HTTP urls, but doing that causes the tests to
fail more often -- they start to fail on Windows. I investigated the
failures and can't see a good way of fixing them
(https://crbug.com/703727#c8) so I'm disabling them in the meanwhile.

BUG=594215
==========

[wjmaclean, 2017-04-07 18:04:04]

On 2017/04/07 17:36:48, Mustafa Emre Acer wrote:
> On 2017/04/07 16:40:08, wjmaclean wrote:
> > On 2017/04/05 20:34:32, Mustafa Emre Acer wrote:
> > > wjmaclean: Can you PTAL? Thanks.
> > 
> > I'm not sure I understand what you mean by
> > 
> > "Changing these tests to navigate to non-data URLs will manifest the flakes
on
> > all platforms"
> > 
> > Could you please reword this?
> 
> Sorry for the vague wording. After crrev.com/2702503002 lands, these test will
> stop working because they navigate to data URLs. The fix is to change the data
> URLs in these tests to HTTP urls, but doing that causes the tests to fail more
> often -- they start to fail on Windows. I investigated the failures and can't
> see a good way of fixing them
> (https://bugs.chromium.org/p/chromium/issues/detail?id=703727#c8) so I'd like
to
> disable them in the meanwhile.

Ahh, ok ... totally clear now :-)

I'm lgtm, but could I ask you to file a bug for the test to be updated?

[meacer, 2017-04-07 18:09:51]

On 2017/04/07 18:04:04, wjmaclean wrote:
> On 2017/04/07 17:36:48, Mustafa Emre Acer wrote:
> > On 2017/04/07 16:40:08, wjmaclean wrote:
> > > On 2017/04/05 20:34:32, Mustafa Emre Acer wrote:
> > > > wjmaclean: Can you PTAL? Thanks.
> > > 
> > > I'm not sure I understand what you mean by
> > > 
> > > "Changing these tests to navigate to non-data URLs will manifest the
flakes
> on
> > > all platforms"
> > > 
> > > Could you please reword this?
> > 
> > Sorry for the vague wording. After crrev.com/2702503002 lands, these test
will
> > stop working because they navigate to data URLs. The fix is to change the
data
> > URLs in these tests to HTTP urls, but doing that causes the tests to fail
more
> > often -- they start to fail on Windows. I investigated the failures and
can't
> > see a good way of fixing them
> > (https://bugs.chromium.org/p/chromium/issues/detail?id=703727#c8) so I'd
like
> to
> > disable them in the meanwhile.
> 
> Ahh, ok ... totally clear now :-)
> 
> I'm lgtm, but could I ask you to file a bug for the test to be updated?

Thanks :) Filed https://crbug.com/709541 to update the tests.

[meacer, 2017-04-07 18:09:58]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:10:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:05:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491588598620840,
"parent_rev": "04b9338b15bb938550a0bc904ee769a2d73cdfe3", "commit_rev":
"158cc5cd0ffef904f0449bb4ea59a9f49f049818"}

[commit-bot: I haz the power, 2017-04-07 19:05:53]

Description was changed from

==========
Disable flaky tests that are going to be broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. After crrev.com/2702503002 lands, these test will
stop working because they navigate to data URLs. The fix is to change the
data URLs in these tests to HTTP urls, but doing that causes the tests to
fail more often -- they start to fail on Windows. I investigated the
failures and can't see a good way of fixing them
(https://crbug.com/703727#c8) so I'm disabling them in the meanwhile.

BUG=594215
==========

to

==========
Disable flaky tests that are going to be broken by data URL deprecation

Content-initiated main-frame navigations to data URLs are being blocked
in crbug.com/594215. After crrev.com/2702503002 lands, these test will
stop working because they navigate to data URLs. The fix is to change the
data URLs in these tests to HTTP urls, but doing that causes the tests to
fail more often -- they start to fail on Windows. I investigated the
failures and can't see a good way of fixing them
(https://crbug.com/703727#c8) so I'm disabling them in the meanwhile.

BUG=594215

Review-Url: https://codereview.chromium.org/2803813002
Cr-Commit-Position: refs/heads/master@{#462948}
Committed:
https://chromium.googlesource.com/chromium/src/+/158cc5cd0ffef904f0449bb4ea59...
==========

[commit-bot: I haz the power, 2017-04-07 19:05:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/158cc5cd0ffef904f0449bb4ea59...