Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Issue 2805693002: PlzNavigate: add DumpWithoutCrashing for invalid main resource request. (Closed)

Created:
3 years, 8 months ago by arthursonzogni
Modified:
3 years, 8 months ago
Reviewers:
clamy
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: add DumpWithoutCrashing for invalid main resource request. This CL is an attempt to solve https://crbug.com/705508 A DumpWithoutCrashing is added on the renderer side to get more informations. BUG=705508 Review-Url: https://codereview.chromium.org/2805693002 Cr-Commit-Position: refs/heads/master@{#462517} Committed: https://chromium.googlesource.com/chromium/src/+/35be0078448bc5bc5198eac37562089682a555c1

Patch Set 1 #

Patch Set 2 : Nit. #

Total comments: 1

Patch Set 3 : Add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/child/web_url_loader_impl.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
arthursonzogni
Hi Camille, Please take a look. Thanks!
3 years, 8 months ago (2017-04-06 14:43:57 UTC) #4
clamy
Thanks! Lgtm with a comment. https://codereview.chromium.org/2805693002/diff/20001/content/child/web_url_loader_impl.cc File content/child/web_url_loader_impl.cc (right): https://codereview.chromium.org/2805693002/diff/20001/content/child/web_url_loader_impl.cc#newcode617 content/child/web_url_loader_impl.cc:617: // browser. This should ...
3 years, 8 months ago (2017-04-06 15:02:50 UTC) #5
arthursonzogni
On 2017/04/06 15:02:50, clamy (slow) wrote: > Thanks! Lgtm with a comment. > > https://codereview.chromium.org/2805693002/diff/20001/content/child/web_url_loader_impl.cc ...
3 years, 8 months ago (2017-04-06 15:09:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805693002/40001
3 years, 8 months ago (2017-04-06 15:09:52 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 17:05:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/35be0078448bc5bc5198eac37562...

Powered by Google App Engine
This is Rietveld 408576698