Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2817883003: WebUI: Add PrintPreviewUI::PdfPreviewUI. (Closed)

Created:
3 years, 8 months ago by arthursonzogni
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, Dan Beam
CC:
chromium-reviews, Charlie Reis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Add PrintPreviewUI::PdfPreviewUI. The chrome://print/ WebUI uses the PrintPreviewUI WebUIController object. This page also contains a WebUI iframe and this page shouldn't use the same WebUIController object as the main frame. This CL introduce the PrintPreviewUI::PdfPreviewUI WebUIController object that is associated with this subframe. This WebUIController does nothing for the moment. BUG=704327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
arthursonzogni
Hi Lei, Please take a look and tell me what do you think of this. ...
3 years, 8 months ago (2017-04-14 07:32:38 UTC) #6
Lei Zhang
We are both OOO Friday. Will sleep on it and get back to you next ...
3 years, 8 months ago (2017-04-14 07:37:33 UTC) #7
Dan Beam
i would prefer if we just changed the origin of the preview pane if we ...
3 years, 8 months ago (2017-04-18 02:34:23 UTC) #8
Lei Zhang
3 years, 8 months ago (2017-04-18 22:10:28 UTC) #9
Thanks for trying this out, but it looks like
https://codereview.chromium.org/2810583006/ is the better solution.

Powered by Google App Engine
This is Rietveld 408576698