Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2824753002: v8binding: Updates results of xss-DENIED-window-name-navigator. (Closed)

Created:
3 years, 8 months ago by Yuki
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

v8binding: Updates results of xss-DENIED-window-name-navigator. Due to the revert at https://crrev.com/2753773003 , this CL updates the test result before re-enabling the test. BUG=686470 Review-Url: https://codereview.chromium.org/2824753002 Cr-Commit-Position: refs/heads/master@{#464919} Committed: https://chromium.googlesource.com/chromium/src/+/fff67c6c52d925d712d09b0674142f85c18a0a5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-window-name-navigator-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yuki
Could you review this CL?
3 years, 8 months ago (2017-04-17 09:28:53 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-17 13:15:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824753002/1
3 years, 8 months ago (2017-04-17 13:49:28 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 13:52:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fff67c6c52d925d712d09b067414...

Powered by Google App Engine
This is Rietveld 408576698