Google Git
Sign in
chromium / chromium / src / 2828b9aff274de87efa0619f02e529a17799c49b
commit2828b9aff274de87efa0619f02e529a17799c49b[log] [tgz]
authorDavid Grogan <dgrogan@chromium.org>Tue Jan 15 02:33:55 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jan 15 02:33:55 2019
tree89dbd274c93211fd74d2d49fbe915a86d02dd5a1
parente7ec34625844aa9cf12b3dad7c94ae899bcb51cb [diff]
[LayoutNG] Fix bug in resolving flex-basis:auto

When a column flexbox and an item had orthogonal writing modes (meaning
the child's inline direction matches the container's main axis), we were
using the item's max content size in the parent's writing mode to
resolve its flex-basis, but we should have been using it in the child's
writing mode.

Bug: 845235
Change-Id: I53bd5ba39f9c8cb4ac84dc4638c8abc57e38f974
Reviewed-on: https://chromium-review.googlesource.com/c/1409810
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622688}
2 files changed
tree: 89dbd274c93211fd74d2d49fbe915a86d02dd5a1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .