Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2835603004: v8binding: Removes an unnecessary expectation file of a LayoutTest. (Closed)

Created:
3 years, 8 months ago by Yuki
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

v8binding: Removes an unnecessary expectation file of a LayoutTest. http/tests/security/xss-DENIED-window-name-navigator.html has no behavior specific to mac-retina + mojo-loading. LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator-expected.txt is simply unnecessary. BUG=686470 Review-Url: https://codereview.chromium.org/2835603004 Cr-Commit-Position: refs/heads/master@{#466310} Committed: https://chromium.googlesource.com/chromium/src/+/0ea14ae14aa944a93b46bb888c1aa21261ea3c62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/security/xss-DENIED-window-name-navigator-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Yuki
Could you review this CL? The revert at https://crrev.com/2820103008 was caused by this file. We ...
3 years, 8 months ago (2017-04-21 09:35:21 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-21 09:49:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835603004/1
3 years, 8 months ago (2017-04-21 09:53:50 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 10:59:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ea14ae14aa944a93b46bb888c1a...

Powered by Google App Engine
This is Rietveld 408576698