Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2844393003: Remove dead Page Info permission strings and associated code. (Closed)

Created:
3 years, 7 months ago by lgarron
Modified:
3 years, 7 months ago
Reviewers:
estark
CC:
chromium-reviews, lgarron+watch_chromium.org, mac-reviews_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead Page Info permission strings and associated code. BUG=709701

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/page_info/page_info_ui.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/page_info/page_info_ui.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M components/page_info_strings.grdp View 1 1 chunk +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (5 generated)
lgarron
estark@, could you review?
3 years, 7 months ago (2017-04-28 03:03:02 UTC) #3
estark
3 years, 7 months ago (2017-04-28 05:12:59 UTC) #7
lgtm mod red bots

Powered by Google App Engine
This is Rietveld 408576698