| commit | 318717747560914c8052a2d072d20d0542c16fb7 | [log] [tgz] |
|---|---|---|
| author | ksakamoto@chromium.org <ksakamoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | Tue Jul 22 11:32:40 2014 |
| committer | ksakamoto@chromium.org <ksakamoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | Tue Jul 22 11:32:40 2014 |
| tree | ac1c259f8b42372a1fa45103a0c0187c09b718d4 | |
| parent | 74c10312abe91f486293259a7d2aefa303410573 [diff] |
Revert of High resolution timer fix for Windows (https://codereview.chromium.org/395913006/) Reason for revert: This patch seems to make following browser_tests flakey PPAPINaClNewlibTest.Graphics2D_FlushOffscreenUpdate NetInternalsTest.netInternalsHSTSViewAddOverwrite NetInternalsTest.netInternalsHSTSViewAddDelete NetInternalsTest.netInternalsHSTSViewAddTwice http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34734 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32086 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/47545 Original issue's description: > This is jamesr@ code I am landing. > > On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it was buggy: > > 1- A short task that was not followed by any other task will leave the systemwide timer pegged to 1ms > > 2- After we decided to crank up the timer we would 'lease' the timer for 1 second, for no good reason. > > Both issues are detrimental to battery power. > > The source of both problems is that we tried to decide with incomplete information. This patch solves that by having 1 bit for each pending task that requires a high resolution timer and a sum of the number of tasks that require high res timers. > > BUG=153139 > TEST=included here, also see the bug for manual testing. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284625 TBR=jamesr@chromium.org,darin@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=153139 Review URL: https://codereview.chromium.org/407073004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284664 0039d316-1c4b-4281-b951-d872f2087c98