Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

See crbug.com/620756 for a follow-up bug.

BUG=716296

[lgarron, 2017-04-28 03:13:34]

lgarron@chromium.org changed reviewers:
+ estark@chromium.org, kkhorimoto@chromium.org, meacer@chromium.org

[lgarron, 2017-04-28 03:13:35]

estark@, meacer@, kkhorimoto@: could you review?

[lgarron, 2017-04-28 03:13:37]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 03:14:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-04-28 03:14:23]

Description was changed from

==========
Unify semantically duplicated Page Info strings.

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

BUG=704788, 716296
==========

to

==========
Unify semantically duplicated Page Info strings (cookies, unencrypted basic
auth).

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

BUG=704788, 716296
==========

[commit-bot: I haz the power, 2017-04-28 03:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:37:10]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[estark, 2017-04-28 04:49:31]

lgtm once the bots are happy

https://codereview.chromium.org/2847863004/diff/1/ios/chrome/browser/ui/dialo...
File ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm (right):

https://codereview.chromium.org/2847863004/diff/1/ios/chrome/browser/ui/dialo...
ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm:29:
l10n_util::GetNSString(IDS_PAGEINFO_NOT_SECURE_SUMMARY);
It's a little weird that these http auth dialogs use PAGEINFO strings, isn't it?
Do they have anything to do with page info or does the string just happen to be
appropriate?

[meacer, 2017-04-28 15:28:41]

https://codereview.chromium.org/2847863004/diff/1/ios/chrome/browser/ui/dialo...
File ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm (right):

https://codereview.chromium.org/2847863004/diff/1/ios/chrome/browser/ui/dialo...
ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm:29:
l10n_util::GetNSString(IDS_PAGEINFO_NOT_SECURE_SUMMARY);
On 2017/04/28 04:49:31, estark wrote:
> It's a little weird that these http auth dialogs use PAGEINFO strings, isn't
it?
> Do they have anything to do with page info or does the string just happen to
be
> appropriate?

ISTR they were added when we decided we couldn't reliably display SSL info on
the HTTP auth dialog. I wonder why it always says "not secure" though, that
doesn't sound right. It could be for proxy auth dialogs, I'll need to check.

[lgarron, 2017-05-03 02:22:36]

Description was changed from

==========
Unify semantically duplicated Page Info strings (cookies, unencrypted basic
auth).

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

BUG=704788, 716296
==========

to

==========
Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

See crbug.com/620756 for a follow-up bug.

BUG=716296
==========

[lgarron, 2017-05-03 02:23:50]

lgarron@chromium.org changed reviewers:
+ asanka@chromium.org

[lgarron, 2017-05-03 02:23:50]

meacer@, kkhorimoto@, asanka@: could you review?

[asanka, 2017-05-03 02:34:02]

lgtm

[meacer, 2017-05-03 04:04:39]

lgtm

[sdefresne, 2017-05-03 09:05:41]

Description was changed from

==========
Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

See crbug.com/620756 for a follow-up bug.

BUG=716296
==========

to

==========
Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

This will update HTTP Basic auth dialogs for HTTP pages to state "is not secure"
instead of "is not private", bringing it the string in sync with Material Page
Info.

See crbug.com/620756 for a follow-up bug.

BUG=716296
==========

[lgarron, 2017-05-03 23:22:29]

On 2017/05/03 at 04:04:39, meacer wrote:
> lgtm

I moved this into https://crrev.com/2849713003 to avoid commit queue
babysitting.

[kkhorimoto, 2017-05-04 00:02:49]

lgtm