Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2852623002: Revert of [turbofan] General consolidation of element access. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] General consolidation of element access. (patchset #1 id:1 of https://codereview.chromium.org/2836913004/ ) Reason for revert: Breaks load:tools:drive story Original issue's description: > [turbofan] General consolidation of element access. > > Avoid TransitionElementsKind when storing to objects which only differ > in holeyness of their elements kind. Instead go for polymorphic > CheckMaps, which can often by optimized and avoid the mutation of the > array map. > > This generalizes the approach https://codereview.chromium.org/2836943003 > which covered only element loads. > > R=yangguo@chromium.org > BUG=v8:5267 > > Review-Url: https://codereview.chromium.org/2836913004 > Cr-Commit-Position: refs/heads/master@{#44828} > Committed: https://chromium.googlesource.com/v8/v8/+/ed573cee5c1d1e42158829dc0b92fb697234e121 TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5267, chromium:715936 Review-Url: https://codereview.chromium.org/2852623002 Cr-Commit-Position: refs/heads/master@{#44958} Committed: https://chromium.googlesource.com/v8/v8/+/53d31d0623bd88ce9a0041a767f36eafd3f1de8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M src/compiler/access-info.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/access-info.cc View 3 chunks +39 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Benedikt Meurer
Created Revert of [turbofan] General consolidation of element access.
3 years, 7 months ago (2017-04-28 05:04:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852623002/1
3 years, 7 months ago (2017-04-28 05:05:24 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:40:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/53d31d0623bd88ce9a0041a767f36eafd3f...

Powered by Google App Engine
This is Rietveld 408576698