Use constexpr TaskTraits constructor in device.

Use constexpr TaskTraits constructor in device.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG=713683
R=gab@chromium.org,reillyg@chromium.org
TBR=mcchou@chromium.org

Review-Url: https://codereview.chromium.org/2855233002
Cr-Commit-Position: refs/heads/master@{#469173}
Committed: https://chromium.googlesource.com/chromium/src/+/d25ae560c5b6483ed338c89c96636ab9dc73d43b

[fdoray, 2017-05-03 20:22:11]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-05-03 20:22:13]

gab@: PTAL

The change will then be TBRed to the owner.

[commit-bot: I haz the power, 2017-05-03 20:22:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-05-03 20:27:00]

https://codereview.chromium.org/2855233002/diff/1/device/usb/usb_service_impl.cc
File device/usb/usb_service_impl.cc (right):

https://codereview.chromium.org/2855233002/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:331:
base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},
Since these are the same traits I use in UsbService::CreateBlockingTaskRunner
can you define these as a static constexpr there so that I can simply refer to
them here?

[Reilly Grant (use Gerrit), 2017-05-03 20:27:39]

Description was changed from

==========
Use constexpr TaskTraits constructor in device.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG=713683
R=gab@chromium.org
TBR=mcchou@chromium.org, reillyg@chromium.org
==========

to

==========
Use constexpr TaskTraits constructor in device.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG=713683
R=gab@chromium.org,reillyg@chromium.org
TBR=mcchou@chromium.org
==========

[fdoray, 2017-05-03 20:45:44]

https://codereview.chromium.org/2855233002/diff/1/device/usb/usb_service_impl.cc
File device/usb/usb_service_impl.cc (right):

https://codereview.chromium.org/2855233002/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:331:
base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},
On 2017/05/03 20:27:00, Reilly Grant wrote:
> Since these are the same traits I use in UsbService::CreateBlockingTaskRunner
> can you define these as a static constexpr there so that I can simply refer to
> them here?

This would indeed be a nice improvement but in the context of automated mass
refactoring we do not have the bandwidth for such per file changes and leave it
up to the owners to fix up local tweaks.

[Reilly Grant (use Gerrit), 2017-05-03 20:51:51]

lgtm, I'll submit a cleanup in a later patch.

[gab, 2017-05-03 21:13:16]

lgtm

[fdoray, 2017-05-03 21:33:33]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-05-03 21:33:37]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-03 21:34:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:34:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493847217693250, "parent_rev":
"ecae763d2aaead2c51cfedd0628ec74be4cad7b2", "commit_rev":
"d25ae560c5b6483ed338c89c96636ab9dc73d43b"}

[commit-bot: I haz the power, 2017-05-03 22:34:58]

Description was changed from

==========
Use constexpr TaskTraits constructor in device.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG=713683
R=gab@chromium.org,reillyg@chromium.org
TBR=mcchou@chromium.org
==========

to

==========
Use constexpr TaskTraits constructor in device.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG=713683
R=gab@chromium.org,reillyg@chromium.org
TBR=mcchou@chromium.org

Review-Url: https://codereview.chromium.org/2855233002
Cr-Commit-Position: refs/heads/master@{#469173}
Committed:
https://chromium.googlesource.com/chromium/src/+/d25ae560c5b6483ed338c89c9663...
==========

[commit-bot: I haz the power, 2017-05-03 22:34:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d25ae560c5b6483ed338c89c9663...