Fix SpdySessionKey for HTTP/2 alternative Jobs.

Fix SpdySessionKey for HTTP/2 alternative Jobs.

Change HttpStreamFactoryImpl::Job::GetSpdySessionKey() to construct a
SpdySessionKey from the request URL, not the destination.  This is the
correct behavior, because the only layers that should worry about the
destination are the socket pool and below.

This does not change behavior in production, because
HostPortPair::FromURL(origin_url_) can only differ from |destination_|
for alternative jobs, and HTTP/2 alternative jobs are disabled in
https://crrev.com/2821463002.

BUG=615413, 706974
Review-Url: https://codereview.chromium.org/2887773006
Cr-Commit-Position: refs/heads/master@{#472919}
Committed: https://chromium.googlesource.com/chromium/src/+/1fc76912bc055188dc76c09f6032096c079d4d86

[Bence, 2017-05-17 18:01:34]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:03:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-05-17 18:28:23]

Description was changed from

==========
Fix SpdySessionKey for HTTP/2 alternative Jobs.

Change HttpStreamFactoryImpl::Job::GetSpdySessionKey() to construct a
SpdySessionKey from the request URL, not the destination.  This is the
correct behavior, because the only layers that should worry about the
destination are the socket pool and below.

This does not change behavior in production, because
HostPortPair::FromURL(origin_url_) can only differ from |destination_|
for alternative jobs, and HTTP/2 alternative jobs are disabled in
https://crrev.com/2821463002.

BUG=706974
==========

to

==========
Fix SpdySessionKey for HTTP/2 alternative Jobs.

Change HttpStreamFactoryImpl::Job::GetSpdySessionKey() to construct a
SpdySessionKey from the request URL, not the destination.  This is the
correct behavior, because the only layers that should worry about the
destination are the socket pool and below.

This does not change behavior in production, because
HostPortPair::FromURL(origin_url_) can only differ from |destination_|
for alternative jobs, and HTTP/2 alternative jobs are disabled in
https://crrev.com/2821463002.

BUG=615413, 706974
==========

[commit-bot: I haz the power, 2017-05-17 20:21:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:21:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bence, 2017-05-17 22:42:14]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-05-17 22:42:14]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2017-05-17 23:02:13]

looks good. can we get a regression test?

[Bence, 2017-05-18 16:11:11]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:12:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:13:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Bence, 2017-05-18 18:22:39]

Ryan: PTAL.

Oops, how could I have forgotten about the regression test?!  Thanks for
reminding me.

On 2017/05/17 23:02:13, Ryan Hamilton wrote:
> looks good. can we get a regression test?

[Ryan Hamilton, 2017-05-18 18:31:31]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-05-18 18:31:31]

lgtm

[commit-bot: I haz the power, 2017-05-18 18:33:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 20:43:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495132291283440,
"parent_rev": "0aa5c726da0324909f7d891f2ca033c115edc372", "commit_rev":
"1fc76912bc055188dc76c09f6032096c079d4d86"}

[commit-bot: I haz the power, 2017-05-18 20:43:42]

Description was changed from

==========
Fix SpdySessionKey for HTTP/2 alternative Jobs.

Change HttpStreamFactoryImpl::Job::GetSpdySessionKey() to construct a
SpdySessionKey from the request URL, not the destination.  This is the
correct behavior, because the only layers that should worry about the
destination are the socket pool and below.

This does not change behavior in production, because
HostPortPair::FromURL(origin_url_) can only differ from |destination_|
for alternative jobs, and HTTP/2 alternative jobs are disabled in
https://crrev.com/2821463002.

BUG=615413, 706974
==========

to

==========
Fix SpdySessionKey for HTTP/2 alternative Jobs.

Change HttpStreamFactoryImpl::Job::GetSpdySessionKey() to construct a
SpdySessionKey from the request URL, not the destination.  This is the
correct behavior, because the only layers that should worry about the
destination are the socket pool and below.

This does not change behavior in production, because
HostPortPair::FromURL(origin_url_) can only differ from |destination_|
for alternative jobs, and HTTP/2 alternative jobs are disabled in
https://crrev.com/2821463002.

BUG=615413, 706974

Review-Url: https://codereview.chromium.org/2887773006
Cr-Commit-Position: refs/heads/master@{#472919}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fc76912bc055188dc76c09f6032...
==========

[commit-bot: I haz the power, 2017-05-18 20:43:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1fc76912bc055188dc76c09f6032...