Revert "Reland "Switch to passing command lines via an isolated file.""

This reverts commit 59f6be1cfda531f5b1172bc9f3ec6d1828cacd1e.

Reason for revert: Broken again: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56855

Original change's description:
> Reland "Switch to passing command lines via an isolated file."
> 
> This reverts commit b4bbf936a543619f153aaf5cef64666c12ef0250.
> 
> Reason for revert: relanding with fix to set the default isolate server property.
> 
> Original change's description:
> > Revert "Switch to passing command lines via an isolated file."
> > 
> > This reverts commit 048f05489b0cd7e017adf8671f45267e39f4798d.
> > 
> > Reason for revert: assert self._server AssertionErrors
> > eg: https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20dEQP%20Builder/64940
> > 
> > Original change's description:
> > > Switch to passing command lines via an isolated file.
> > > 
> > > It turns out that passing command lines via builder properties
> > > causes the command line that kitchen uses to run a chromium recipe to
> > > exceed 32k (the max) on Windows.
> > > 
> > > So, this CL switches to passing command lines from builder to
> > > tester via a file uploaded and downloaded from the isolate server;
> > > this should be quite robust.
> > > 
> > > [ This is option 2B from
> > > https://docs.google.com/document/d/1UA-3h2Mmqr3BqfEfLFubveFJIk_52T9sBFgC7MShPJ4/edit?usp=sharing ].
> > > 
> > > Bug: 1108005
> > > Change-Id: I4e823ff3d6f4f73d0af643246b641d75f79c69ad
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2347247
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > 
> > TBR=dpranke@google.com,martiniss@chromium.org,tikuta@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com
> > 
> > Change-Id: I400f23b674bc6a4ef2f32ae81f30a1c26badcfac
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1108005, 1115200
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2349668
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Commit-Queue: Ben Pastene <bpastene@chromium.org>
> 
> TBR=dpranke@google.com,martiniss@chromium.org,tikuta@chromium.org,bpastene@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1108005
> Bug: 1115200
> Change-Id: I6081a01300562e57adb0f7b088c5f196e5d28442
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2350319
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>

TBR=dpranke@google.com,martiniss@chromium.org,tikuta@chromium.org,bpastene@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I02d0af36ca702ef7d78be2da007437f8f63fea34
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1108005
Bug: 1115200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2350337
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
15 files changed
tree: 839fdf94cf759a83215a18a7fb730a263e80053a
  1. infra/
  2. scripts/
  3. site_config/
  4. third_party/
  5. .gitattributes
  6. .gitignore
  7. .style.yapf
  8. .vpython
  9. .yapfignore
  10. codereview.settings
  11. CROS_OWNERS
  12. DEPS
  13. environment.cfg.py
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. WATCHLISTS
README.md

Recipes

If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format) to autoformat new code.