commit | 28b418dcd520e68d1329c631e5494194baf1061a | [log] [tgz] |
---|---|---|
author | Wez <wez@chromium.org> | Sat Jan 06 21:18:59 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Jan 07 00:40:09 2018 |
tree | 8b660a3009248a38876c24a3bdd09fbe205ad21c | |
parent | f0bf3de8e459fb06dd4ab30c7bd36fa7fbcad949 [diff] |
Revert "Proper MessageLoop::IsIdleForTesting() that corresponds to the actual idleness criteria for MessageLoop." This reverts commit f9c93846970ae6ddd7b9cca352571bdd718ca43d. Reason for revert: Changing the semantics of IsIdleForTesting() breaks the semantics expected by many tests, in particular meaning that the result is (more) affected by timing, since ready-to-run delayed tasks are now included in the calculation. This has introduced substantial flakiness to the Fuchsia bots on the CQ/waterfall & FYI tree, since they run under emulation and so often enjoy significant thread scheduling delays. Original change's description: > Proper MessageLoop::IsIdleForTesting() that corresponds to the actual idleness criteria for MessageLoop. > > A pre-requirement for a simpler ScopedTaskEnvironment::RunUntilIdle() > implementation. > > R=fdoray@chromium.org > > Bug: 708584 > Change-Id: I6c35d72868ab313788c166c76e179c8cd3ace438 > Reviewed-on: https://chromium-review.googlesource.com/847752 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526750} TBR=gab@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 708584 Change-Id: Ie051c747edb468c1a7b13f1f0c2b862b4052505e Reviewed-on: https://chromium-review.googlesource.com/853091 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#527529}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .