Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 2945333002: [Cleanup] Remove a couple of type="int" attributes that snuck in. (Closed)

Created:
3 years, 6 months ago by Ilya Sherman
Modified:
3 years, 6 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Remove a couple of type="int" attributes that snuck in. This attribute was deprecated in https://codereview.chromium.org/2941623002 Also, run "git cl format" to clean up histograms.xml a bit. BUG=735364 TEST=presubmit R=holte@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/metrics/histograms/enums.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Ilya Sherman
3 years, 6 months ago (2017-06-21 19:48:47 UTC) #1
Steven Holte
lgtm
3 years, 6 months ago (2017-06-21 19:52:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945333002/1
3 years, 6 months ago (2017-06-21 19:53:23 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 22:29:17 UTC) #9
Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698