| commit | 29509aa87a6785e3fcfd5e6b52407a6a6194f239 | [log] [tgz] |
|---|---|---|
| author | Dirk Pranke <dpranke@google.com> | Thu Oct 01 01:54:57 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 01 01:54:57 2020 |
| tree | 37286f4a7a2e8c8e77bd5456601f999af1bcaecd | |
| parent | f2c91fd32ea5b1762ea2509a868c9b9d7ec72405 [diff] |
Reland "Remove --isolated-script-test-perf-output from chromium recipe." This is a reland of 98cb0022b0e4f2c6b05a23b31bfe532ed9924885. It turned out that the arg was used way in at least one place. That usage was removed in https://crrev.com/c/2429866, so let's try to land this again and see what happens. Original change's description: > Remove --isolated-script-test-perf-output from chromium recipe. > > As discovered/discussed in crbug.com/1127545, it appears that this > flag is not actually ever used anywhere in the chromium recipes. > > Perf tests *do* produce output, but they don't use this flag to > do so. > > WebRTC tests *do* use this flag, but they set this directly in their > own recipes. > > Bug: 1127545 > Change-Id: I215ad8f698c18e41ca2a87c7043371a9ac73000b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2427305 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> TBR=martiniss@chromium.org Bug: 1127545 Change-Id: I57743d353893d310adafe88df7c0fcc7858c9048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2431697 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.