commit | 29b9eafeffa528388b7a3ed568f3abefd6de0594 | [log] [tgz] |
---|---|---|
author | Christian Biesinger <cbiesinger@chromium.org> | Thu Jun 28 00:02:33 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 28 00:02:33 2018 |
tree | f4d24bb2e9d588362bb8371ed370778821d8cb97 | |
parent | 04007607ad8d140597024f27800e794261591f22 [diff] |
[layoutng] Override computeIntrinsicLogicalWidths so we can use the NG code for it This is mostly straightforward, except that on Mac, we may have to compute intrinsic sizes outside of layout. So this patch also adds special code to avoid layout calls in such cases (for orthogonal flows). However, this also required me to change some tests to have the correct "inside of layout" state. Notes on tests: fast/dynamic/012.html Had an incorrect rebaseline; rendering matches legacy modulo text splitting (positioning is the same) css2.1/20110323/table-height-algorithm-023.htm css2.1/20110323/table-height-algorithm-024.htm Parts of these tests were already using the smaller size due to 1px text rendering differences; this rebaseline just makes us more consistent. tables/mozilla/bugs/bug57828.html Also a trivial 1px difference tables/mozilla/bugs/bug60992.html Probably an issue of bug 40634; legacy takes the whitespace before <br> (here, a linebreak) into account for calculating the width of the cell and NG does not. tables/mozilla_expected_failures/bugs/bug1010.html Also 1px and 2px text rendering difference virtual/layout_ng_experimental/external/wpt/css/css-flexbox/flexbox_stf-table-caption.html Fails for an unrelated reason, see newly filed bug 857185 Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia11317acd777aec201702fce28ebab74dba99b4f Reviewed-on: https://chromium-review.googlesource.com/508293 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#570953}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .