commit | 2a3c852f4b08efee3c2fa013c68d683bd1b893bc | [log] [tgz] |
---|---|---|
author | Alan Cutter <alancutter@chromium.org> | Fri Nov 30 01:02:48 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 30 01:02:48 2018 |
tree | 4ee3df55b4a433a869f64d25c067d7a29259684c | |
parent | 6d4576ad4644c9a41e7801d635d3894a2f783ed2 [diff] |
Revert "Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows" This reverts commit 6d4576ad4644c9a41e7801d635d3894a2f783ed2. Reason for revert: On second thought this is too risky to land on branch day. Also I want to land the new binary separately from the shortcuts pointing to it so we can make sure it deploys properly before irreversibly depending on it (it's difficult to update shortcuts). Original change's description: > Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows > > This change adds a new executable to Windows called chrome_proxy.exe which > opens chrome.exe with all arguments forwarded. > > The purpose of the executable is for bookmark app shortcuts to target so > they don't pick up the chrome.VisualElementsManifest.xml file when pinned > to the Windows 10 start menu. This fixes a bug where pinned bookmark app > shortcuts all use the Chrome logo instead of their own. > > Bug: 732357 > Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1335075 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612477} TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org Change-Id: If327a489864c0bd6066ec13b3f9421f3be57636b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732357 Reviewed-on: https://chromium-review.googlesource.com/c/1356163 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612478}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .