| commit | 2a76d152793a2d3a7d89f26912d2af2ca31a2335 | [log] [tgz] |
|---|---|---|
| author | pcc <pcc@chromium.org> | Thu Jun 30 23:34:04 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Jun 30 23:37:14 2016 |
| tree | 5cc95dbdf0c8502fe76589189ee27722339ce8fe | |
| parent | 6ad9d6295756dbc10cbfa1c4563f1dd477343b15 [diff] |
Move TestExtraData classes to anonymous namespace. We were previously declaring two different classes with the name blink::TestExtraData, which is an ODR violation. As it happens, their implementations compiled to the same machine code, which allowed the tests to pass in most normal circumstances. However, the ODR violation causes test failures in CFI mode (e.g. [1]) as a result of stricter type checking. The fix is to move both classes to an anonymous namespace which makes them internal to their TUs. [1] https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5924/steps/webkit_unit_tests/logs/WebURLResponseTest.ExtraData BUG=464797 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2119683002 Cr-Commit-Position: refs/heads/master@{#403338}