Google Git
Sign in
chromium / chromium / src / 2ae89b5690bf34bee4807a949f8e2ce11a61f1b9
commit2ae89b5690bf34bee4807a949f8e2ce11a61f1b9[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Fri Feb 08 07:19:37 2019
committerCommit Bot <commit-bot@chromium.org>Fri Feb 08 07:19:37 2019
treeb210cc0edd652600b31a1c0e23216cd26107ffe7
parent6026fe0b9cecb0702f74713814f7f0996d793730 [diff]
[LayoutNG] Fix LocalVisualRect to include LocalSelectionRect

From the discussion with wangxianzhu@, NG differs from legacy
in that LocalVisualRect does not include LocalSelectionRect,
and it is causing additional computation in PaintInvalidator.

This wasn't the intention, and the fix in PaintInvalidator
lead to additional work in pre-paint phase. This patch fixes
LocalVisualRect to include LocalSelectionRect when it is
selected.

LayoutObject::IsSelected turned out to be slow for this
purpose. Its improvement is in a separate CL:1460576.

Also this change figured out that LocalSelectionRect is in
different coordinate than legacy. Filed issue 930034 for it
to work on later as there might be impacts to other code.

Bug: 636993, 930034
Change-Id: If02d17dbc88e3d7195050d87b8a3b425f4158375
Reviewed-on: https://chromium-review.googlesource.com/c/1457812
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630233}
2 files changed
tree: b210cc0edd652600b31a1c0e23216cd26107ffe7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. services/
  44. skia/
  45. sql/
  46. storage/
  47. styleguide/
  48. testing/
  49. third_party/
  50. tools/
  51. ui/
  52. url/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .