Google Git
Sign in
chromium / chromium / src / 2b38ceb8d26dfd7cd2607935e88ef31a81c38f78
commit2b38ceb8d26dfd7cd2607935e88ef31a81c38f78[log] [tgz]
authorAleks Totic <atotic@chromium.org>Thu Dec 28 17:52:39 2017
committerCommit Bot <commit-bot@chromium.org>Thu Dec 28 21:45:02 2017
tree6a1694a2c62a5c550ca5005fab4d563b99986b87
parent492c2ee6fc6cb259f7c379533c1f1dabe670ab22 [diff]
[LayoutNG] Pass Container() to NGOutOfFlowLayout instead of ContainerBlock()

Fixes external/wpt/css/css-position/position-relative-* DCHECK crashes

Had to modify NGOutOfFlowLayoutPart constructor.

It used to take NGBlockNode to compute scrollbar sizes,
contains_absolute, and contains_fixed.

Containing block can be arbitrary LayoutBoxModelObject with inline blocks.
None of NG*Nodes can be constructed from LayoutBoxModelObject.
=> NGOutOfFlowLayoutPart constructor cannot take NG*Node, but must take
all required LayoutObject properties instead.

Bug: 740993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I731800feddf5d53a9104f62d9d616f56a6195671
Reviewed-on: https://chromium-review.googlesource.com/845499
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526328}
7 files changed
tree: 6a1694a2c62a5c550ca5005fab4d563b99986b87
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .