commit | 2bccb734e64c0e701ee8c795fa11fa2a040bf6c3 | [log] [tgz] |
---|---|---|
author | Leszek Swirski <leszeks@chromium.org> | Fri Aug 17 13:50:56 2018 |
committer | Ross McIlroy <rmcilroy@chromium.org> | Fri Aug 17 13:50:56 2018 |
tree | 1b98973254551802bdba480326bbfa234971b6f2 | |
parent | c39c5812fbd9529e976a111f7e12cb3f39f366e7 [diff] |
Revert "[v8] Re-post non-blocking ScriptStreamer tasks" This reverts commit 5912b768395ab595274c932bd653f9e47a93ec1c. Reason for revert: Seems to cause Scanner crashes Original change's description: > [v8] Re-post non-blocking ScriptStreamer tasks > > Posted blocking ScriptStreamer tasks can end up in a queue, and have > their Resource complete loading before the task even starts. When this > happens, these tasks will no longer block on network input, but they > will still be posted to the blocking task runner, which does not spin up > new threads if the running task is not blocked. When there are a lot of > small functions posted for streaming, this results in a slightly > paradoxical starvation, where the blocking task runner is processing > lots of no-longer-blocking tasks all in one thread, as it has no reason > to spin up new threads. > > To avoid this, if a streaming task isn't started before the resource > finishes loading, we can cancel this posted task, and instead post a new > non-blocking task to the non-blocking thread pool. This frees up the > blocking task runner to process only blocking tasks (and thus allows it > to spin up new threads for them). > > Bug: chromium:865098 > Bug: chromium:866868 > Change-Id: Iceb282582781109ade233366d1009c3be50db3a5 > Reviewed-on: https://chromium-review.googlesource.com/1174380 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583649} TBR=skyostil@google.com,gab@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,skyostil@chromium.org,altimin@chromium.org,leszeks@chromium.org Change-Id: Iffbab7a8994d12ffce53c6b5b76d19f4db79df0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:865098, chromium:866868, chromium:875162 Reviewed-on: https://chromium-review.googlesource.com/1179641 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583995}(cherry picked from commit 63ecc7f1995431a135519633994c45195334bd48) Reviewed-on: https://chromium-review.googlesource.com/1179841 Cr-Commit-Position: refs/branch-heads/3525@{#3} Cr-Branched-From: f7f1772a44a00254f19f4ddae1f8890ef766e1e3-refs/heads/master@{#583911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .