Google Git
Sign in
chromium / chromium / src / 2cdce56d51dd48b27774907f062ae3f469c0df6d
commit2cdce56d51dd48b27774907f062ae3f469c0df6d[log] [tgz]
authorKunihiko Sakamoto <ksakamoto@chromium.org>Fri Dec 21 05:01:35 2018
committerCommit Bot <commit-bot@chromium.org>Fri Dec 21 05:01:35 2018
tree1bf67f99e6184b1ca7bc892bedd6c21f216c388a
parent195bb3ff859179faaa2ee6d087e97772486536c2 [diff]
imagesrcset / imagesizes: Fix candidate selection when imagesizes is absent

This fixes a bug where image source size is calculated to be zero when
<link rel=preload imagesrcset=...> does not have an imagesizes attribute.

If imagesizes attribute is absent or does not have a valid value, it
should be treated as "100vw" [1]. In HTMLPreloadScanner, this is done by
initializing |source_size_| in the StartTagScanner constructor, but we
did not do that for <link> tags.

[1] https://html.spec.whatwg.org/multipage/images.html#parsing-a-sizes-attribute

Bug: 813452
Change-Id: Ib7609c7de2a305d3e7ca142c9ce7f0c5f8cf7e3a
Reviewed-on: https://chromium-review.googlesource.com/c/1388047
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618462}
3 files changed
tree: 1bf67f99e6184b1ca7bc892bedd6c21f216c388a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .