commit | 2d4a955e9008d85f2ab4b6c530484c8b63c4d949 | [log] [tgz] |
---|---|---|
author | Jared Saul <jsaul@google.com> | Wed Jan 09 19:54:49 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 09 19:54:49 2019 |
tree | 3c356a4b0213396b01cbdfab7514af934ae3fdb8 | |
parent | 4157ba1c3c7a78d10887b50fbeda06f1bfb34860 [diff] |
Fix broken metrics collection dialog spacing The change around line 29-30 in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1368409/2/metrics_utils.py inadvertently removed an extra space. As a result, the metrics collection dialog looks like this: https://screenshot.googleplex.com/3aGtquydCXM.png Change-Id: I7c9c08949b0df248e6de4f59ec9cfd573ff40901 Reviewed-on: https://chromium-review.googlesource.com/c/1403577 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.