commit | 2e1bdea8ad80dc63fb5ed19396934db801e69fde | [log] [tgz] |
---|---|---|
author | rmcilroy <rmcilroy@chromium.org> | Tue Nov 03 11:27:54 2015 |
committer | Commit bot <commit-bot@chromium.org> | Tue Nov 03 11:28:04 2015 |
tree | 6fe01ca85050d425f16f0844055df2221529ae7d | |
parent | efcc7fb2bd88393450ca03e5a427fd8dc4e09f1d [diff] |
[Interpreter] Ensure ToBoolean bytecodes are correctly emitted at the start of basic blocks Existing code was assuming that 'lexical' blocks were the same as basic blocks, therefore code which emitted jumps within a lexical block (e.g., logical or) would in some occassions incorrectly omit a necessary ToBoolean. This change removes Enter/LeaveBlock from BytecodeArrayBuilder and instead tracks basic blocks via label bindings and jump operations. The change also ensures we don't emit dead code at the end of a basic block, and adds tests of the edge cases. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1406983010 Cr-Commit-Position: refs/heads/master@{#31741}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://code.google.com/p/v8/
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.