| // Copyright 2014 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu.h" |
| |
| #include <stddef.h> |
| |
| #include <memory> |
| #include <string> |
| #include <utility> |
| #include <vector> |
| |
| #include "base/compiler_specific.h" |
| #include "base/strings/utf_string_conversions.h" |
| #include "base/threading/sequenced_worker_pool.h" |
| #include "base/values.h" |
| #include "build/build_config.h" |
| #include "chrome/app/chrome_command_ids.h" |
| #include "chrome/browser/bookmarks/bookmark_model_factory.h" |
| #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h" |
| #include "chrome/browser/profiles/profile.h" |
| #include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h" |
| #include "chrome/test/base/testing_profile.h" |
| #include "components/bookmarks/browser/bookmark_model.h" |
| #include "components/bookmarks/common/bookmark_pref_names.h" |
| #include "components/bookmarks/managed/managed_bookmark_service.h" |
| #include "components/bookmarks/test/bookmark_test_helpers.h" |
| #include "components/prefs/pref_service.h" |
| #include "content/public/browser/page_navigator.h" |
| #include "content/public/test/test_browser_thread.h" |
| #include "content/public/test/test_browser_thread_bundle.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| #include "ui/base/clipboard/clipboard.h" |
| #include "ui/events/platform/platform_event_source.h" |
| #include "ui/views/controls/menu/menu_item_view.h" |
| |
| #if defined(OS_WIN) |
| #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" |
| #endif |
| |
| using base::ASCIIToUTF16; |
| using bookmarks::BookmarkModel; |
| using bookmarks::BookmarkNode; |
| using content::BrowserThread; |
| using content::OpenURLParams; |
| using content::PageNavigator; |
| using content::WebContents; |
| |
| namespace { |
| |
| // PageNavigator implementation that records the URL. |
| class TestingPageNavigator : public PageNavigator { |
| public: |
| WebContents* OpenURL(const OpenURLParams& params) override { |
| urls_.push_back(params.url); |
| return NULL; |
| } |
| |
| std::vector<GURL> urls_; |
| }; |
| |
| } // namespace |
| |
| class BookmarkContextMenuTest : public testing::Test { |
| public: |
| BookmarkContextMenuTest() : model_(nullptr) {} |
| |
| void SetUp() override { |
| profile_.reset(new TestingProfile()); |
| profile_->CreateBookmarkModel(true); |
| |
| model_ = BookmarkModelFactory::GetForBrowserContext(profile_.get()); |
| bookmarks::test::WaitForBookmarkModelToLoad(model_); |
| |
| AddTestData(); |
| } |
| |
| void TearDown() override { |
| ui::Clipboard::DestroyClipboardForCurrentThread(); |
| |
| BrowserThread::GetBlockingPool()->FlushForTesting(); |
| } |
| |
| protected: |
| content::TestBrowserThreadBundle thread_bundle_; |
| std::unique_ptr<TestingProfile> profile_; |
| BookmarkModel* model_; |
| TestingPageNavigator navigator_; |
| |
| private: |
| // Creates the following structure: |
| // a |
| // F1 |
| // f1a |
| // -f1b as "chrome://settings" |
| // F11 |
| // f11a |
| // F2 |
| // F3 |
| // F4 |
| // f4a |
| void AddTestData() { |
| const BookmarkNode* bb_node = model_->bookmark_bar_node(); |
| std::string test_base = "file:///c:/tmp/"; |
| model_->AddURL(bb_node, 0, ASCIIToUTF16("a"), GURL(test_base + "a")); |
| const BookmarkNode* f1 = model_->AddFolder(bb_node, 1, ASCIIToUTF16("F1")); |
| model_->AddURL(f1, 0, ASCIIToUTF16("f1a"), GURL(test_base + "f1a")); |
| model_->AddURL(f1, 1, ASCIIToUTF16("f1b"), GURL("chrome://settings")); |
| const BookmarkNode* f11 = model_->AddFolder(f1, 2, ASCIIToUTF16("F11")); |
| model_->AddURL(f11, 0, ASCIIToUTF16("f11a"), GURL(test_base + "f11a")); |
| model_->AddFolder(bb_node, 2, ASCIIToUTF16("F2")); |
| model_->AddFolder(bb_node, 3, ASCIIToUTF16("F3")); |
| const BookmarkNode* f4 = model_->AddFolder(bb_node, 4, ASCIIToUTF16("F4")); |
| model_->AddURL(f4, 0, ASCIIToUTF16("f4a"), GURL(test_base + "f4a")); |
| } |
| }; |
| |
| // Tests Deleting from the menu. |
| TEST_F(BookmarkContextMenuTest, DeleteURL) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(0)); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false); |
| GURL url = model_->bookmark_bar_node()->GetChild(0)->url(); |
| ASSERT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| // Delete the URL. |
| controller.ExecuteCommand(IDC_BOOKMARK_BAR_REMOVE, 0); |
| // Model shouldn't have URL anymore. |
| ASSERT_FALSE(model_->IsBookmarked(url)); |
| } |
| |
| // Tests open all on a folder with a couple of bookmarks. |
| TEST_F(BookmarkContextMenuTest, OpenAll) { |
| const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1); |
| chrome::OpenAll(NULL, &navigator_, folder, |
| WindowOpenDisposition::NEW_FOREGROUND_TAB, NULL); |
| |
| // Should have navigated to F1's child but not F11's child. |
| ASSERT_EQ(static_cast<size_t>(2), navigator_.urls_.size()); |
| ASSERT_TRUE(folder->GetChild(0)->url() == navigator_.urls_[0]); |
| } |
| |
| // Tests open all on a folder with a couple of bookmarks in incognito window. |
| TEST_F(BookmarkContextMenuTest, OpenAllIncognito) { |
| const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1); |
| chrome::OpenAll(NULL, &navigator_, folder, |
| WindowOpenDisposition::OFF_THE_RECORD, profile_.get()); |
| |
| // Should have navigated to only f1a but not f2a. |
| ASSERT_EQ(static_cast<size_t>(1), navigator_.urls_.size()); |
| ASSERT_TRUE(folder->GetChild(0)->url() == navigator_.urls_[0]); |
| } |
| |
| // Tests the enabled state of the menus when supplied an empty vector. |
| TEST_F(BookmarkContextMenuTest, EmptyNodes) { |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, model_->other_node(), |
| std::vector<const BookmarkNode*>(), false); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| // Tests the enabled state of the menus when supplied a vector with a single |
| // url. |
| TEST_F(BookmarkContextMenuTest, SingleURL) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(0)); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| // Tests the enabled state of the menus when supplied a vector with multiple |
| // urls. |
| TEST_F(BookmarkContextMenuTest, MultipleURLs) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(0)); |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(1)->GetChild(0)); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| // Tests the enabled state of the menus when supplied an vector with a single |
| // folder. |
| TEST_F(BookmarkContextMenuTest, SingleFolder) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(2)); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| // Tests the enabled state of the menus when supplied a vector with multiple |
| // folders, all of which are empty. |
| TEST_F(BookmarkContextMenuTest, MultipleEmptyFolders) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(2)); |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(3)); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| // Tests the enabled state of the menus when supplied a vector with multiple |
| // folders, some of which contain URLs. |
| TEST_F(BookmarkContextMenuTest, MultipleFoldersWithURLs) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(3)); |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(4)); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_TRUE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_TRUE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| // Tests the enabled state of open incognito. |
| TEST_F(BookmarkContextMenuTest, DisableIncognito) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->bookmark_bar_node()->GetChild(0)); |
| Profile* incognito = profile_->GetOffTheRecordProfile(); |
| BookmarkContextMenu controller( |
| NULL, NULL, incognito, NULL, nodes[0]->parent(), nodes, false); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_INCOGNITO)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| } |
| |
| // Tests that you can't remove/edit when showing the other node. |
| TEST_F(BookmarkContextMenuTest, DisabledItemsWithOtherNode) { |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(model_->other_node()); |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, nodes[0], nodes, false); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_EDIT)); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| } |
| |
| // Tests the enabled state of the menus when supplied an empty vector and null |
| // parent. |
| TEST_F(BookmarkContextMenuTest, EmptyNodesNullParent) { |
| BookmarkContextMenu controller( |
| NULL, NULL, profile_.get(), NULL, NULL, |
| std::vector<const BookmarkNode*>(), false); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO)); |
| EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_REMOVE)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK)); |
| EXPECT_FALSE( |
| controller.IsCommandEnabled(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| } |
| |
| TEST_F(BookmarkContextMenuTest, CutCopyPasteNode) { |
| const BookmarkNode* bb_node = model_->bookmark_bar_node(); |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(bb_node->GetChild(0)); |
| std::unique_ptr<BookmarkContextMenu> controller(new BookmarkContextMenu( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false)); |
| EXPECT_TRUE(controller->IsCommandEnabled(IDC_COPY)); |
| EXPECT_TRUE(controller->IsCommandEnabled(IDC_CUT)); |
| |
| // Copy the URL. |
| controller->ExecuteCommand(IDC_COPY, 0); |
| |
| controller.reset(new BookmarkContextMenu( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false)); |
| int old_count = bb_node->child_count(); |
| controller->ExecuteCommand(IDC_PASTE, 0); |
| |
| ASSERT_TRUE(bb_node->GetChild(1)->is_url()); |
| ASSERT_EQ(old_count + 1, bb_node->child_count()); |
| ASSERT_EQ(bb_node->GetChild(0)->url(), bb_node->GetChild(1)->url()); |
| |
| controller.reset(new BookmarkContextMenu( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false)); |
| // Cut the URL. |
| controller->ExecuteCommand(IDC_CUT, 0); |
| ASSERT_TRUE(bb_node->GetChild(0)->is_url()); |
| ASSERT_TRUE(bb_node->GetChild(1)->is_folder()); |
| ASSERT_EQ(old_count, bb_node->child_count()); |
| } |
| |
| // Tests that the "Show managed bookmarks" option in the context menu is only |
| // visible if the policy is set. |
| TEST_F(BookmarkContextMenuTest, ShowManagedBookmarks) { |
| // Create a BookmarkContextMenu for the bookmarks bar. |
| const BookmarkNode* bb_node = model_->bookmark_bar_node(); |
| std::vector<const BookmarkNode*> nodes; |
| nodes.push_back(bb_node->GetChild(0)); |
| std::unique_ptr<BookmarkContextMenu> controller(new BookmarkContextMenu( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false)); |
| |
| // Verify that there are no managed nodes yet. |
| bookmarks::ManagedBookmarkService* managed = |
| ManagedBookmarkServiceFactory::GetForProfile(profile_.get()); |
| EXPECT_TRUE(managed->managed_node()->empty()); |
| |
| // The context menu should not show the option to "Show managed bookmarks". |
| EXPECT_FALSE( |
| controller->IsCommandVisible(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS)); |
| views::MenuItemView* menu = controller->menu(); |
| EXPECT_FALSE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) |
| ->visible()); |
| |
| // Other options are not affected. |
| EXPECT_TRUE(controller->IsCommandVisible(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_NEW_FOLDER)->visible()); |
| |
| // Now set the managed bookmarks policy. |
| std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue); |
| dict->SetString("name", "Google"); |
| dict->SetString("url", "http://google.com"); |
| base::ListValue list; |
| list.Append(std::move(dict)); |
| EXPECT_TRUE(managed->managed_node()->empty()); |
| profile_->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list); |
| EXPECT_FALSE(managed->managed_node()->empty()); |
| |
| // New context menus now show the "Show managed bookmarks" option. |
| controller.reset(new BookmarkContextMenu( |
| NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false)); |
| EXPECT_TRUE(controller->IsCommandVisible(IDC_BOOKMARK_BAR_NEW_FOLDER)); |
| EXPECT_TRUE( |
| controller->IsCommandVisible(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS)); |
| menu = controller->menu(); |
| EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_NEW_FOLDER)->visible()); |
| EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) |
| ->visible()); |
| } |