commit | 316734d86c3fabd300ad7352dc351d4577f1f87e | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Wed Feb 13 14:19:13 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 13 14:19:13 2019 |
tree | 177a0ea0a4b88899c2c12f8b34dc494ba861f0be | |
parent | 89317beb3ed27d7dd2764d79e12d89cd9c70bc4f [diff] |
FileSystemURL: Stop marking move constructor as noexcept This fixes the GCC build: ../../storage/browser/fileapi/file_system_url.cc:29:1: error: function ‘storage::FileSystemURL::FileSystemURL(storage::FileSystemURL&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ FileSystemURL::FileSystemURL(FileSystemURL&& other) noexcept = default; ^~~~~~~~~~~~~ With GCC, having that noexcept marker requires all members to be marked with noexcept themselves, and at least url::Origin needs the right annotations. Just making FileSystemURL not noexcept is the least intrusive solution for now. clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). Bug: 819294 Change-Id: I7523a048e280c0336559f3b10dce0b82dc7885d6 Reviewed-on: https://chromium-review.googlesource.com/c/1470223 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#631685}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .