commit | 31a486419e279333146ca1e75fcffd510a863d30 | [log] [tgz] |
---|---|---|
author | David 'Digit' Turner <digit@google.com> | Fri Jan 11 16:10:59 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 11 16:10:59 2019 |
tree | 43e7cb418240626d121c99c50e527c155809c9f4 | |
parent | 36248fcd635b13c751d11e6722072bed2d57cb8a [diff] |
Improve no-long-lines check for Python files. The previous implementation of CheckLongLines did not handle global pylint disable/enable directives properly, i.e. the difference between: # pylint: disable=line-too-long .... checks disabled for all lines here. # pylint: enable=line-too-long versus: # Check only disabled for the line below some python statements # pylint: disable=line-too-long This CL changes the implementation to support Python files properly. Note that in order to not disturb the mock-based unit-tests, a new function is introduced to be able to filter the list of affected files based on their file extension. BUG=890734 R=mattcary@chromium.org,ehmaldonado@chromium.org,dpranke@chromium.org Change-Id: Id52deff53913b8d47a4157f42b1fffbd3b103201 Reviewed-on: https://chromium-review.googlesource.com/c/1396094 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: David Turner <digit@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.