commit | 327a4fe16110817e02d1a564ec63ca38908678cc | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Sat Jan 26 00:00:35 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Jan 26 00:00:35 2019 |
tree | 9930cf08e96d2584b4620d371c48ae6f58330e33 | |
parent | 325bed64dc68f6f582f151414c2f05a20ade4cee [diff] |
Push event handling failures up the stack, clear the client early. Have RenderWidget clear itself as the MainThreadEventQueue client when it is closing, in OnClose(). The queue already deals with trying to handle an event when the client is gone. However, it does not deal with the fact that when not handling the event it must still run the mojo reply callback or suffer the wrath of a DCHECK. RenderWidget does deal with this fact already. But instead of dealing with this callback behaviour at multiple levels, have the handle methods return a boolean back up to Dispatch(), where if it gets false it can run HandledEvent() with the failure args from a single place. Remove the closing early outs for MainThreadEventQueue methods in RenderWidget. R=bokan@chromium.org Change-Id: I0f836ed4df801ce470afb10894c9c3caa70c5711 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1435520 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#626269}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .