commit | 32b267c207354cc01f8c39c118e3e7cd8ffcea08 | [log] [tgz] |
---|---|---|
author | Alexey Baskakov <loyso@chromium.org> | Wed Oct 03 00:28:15 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 03 00:28:15 2018 |
tree | 40c2cef707f78bdb4f4fefed545c60c205bd0e88 | |
parent | 758003297868f2c02adcf4fec07ee9ebdef666f6 [diff] |
Revert "CrOS FilesApp: Share crostini entries before opening" This reverts commit dec38a719c28709cbad53804e18db9e96a121c21. Reason for revert: Crashes browser_tests. Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933735011043353616/+/steps/browser_tests/0/stdout Original change's description: > CrOS FilesApp: Share crostini entries before opening > > When a user opens files within Downloads using a crostini app, > show a dialog for the user to give permission to share the > directory that the files are in with crostini. > > * Move handling of 'crostin-files' flag checking into > foreground/js/crostini.js > * Change FileTasks.executeInternal to detect files that > can be shared with crostini and do sharing before execute. > * UI Test verifies share dialog is shown before execute. > * ConvertFileSystemURLToPathInsideCrostini maps > path from within Downloads to '/ChromeOS/Downloads/...' > > Bug: 878324 > Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 > Reviewed-on: https://chromium-review.googlesource.com/c/1243871 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596003} TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org,lucmult@chromium.org Change-Id: I553be4bfe6c0fad8435383c70b44a420237b250b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878324 Reviewed-on: https://chromium-review.googlesource.com/c/1258622 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596067}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .