Google Git
Sign in
chromium / chromium / src / 33642ab33b8e98d381045b35c1af66282ef6acb4
commit33642ab33b8e98d381045b35c1af66282ef6acb4[log] [tgz]
authorVadym Doroshenko <dvadym@chromium.org>Thu Jan 11 19:53:42 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jan 11 19:53:42 2018
treebe49c55b50b6a50ca9089fc8d2a55ac00b65bd1c
parente5e987cf9400e2c23c9dccc6d16ab9efd4f795fe [diff]
Reland "Reland "Do not reveal username value till user gesture.""

This is a reland of 3d4d84928567f74d93d951932eafa1b3d779923b
Original change's description:
> Reland "Do not reveal username value till user gesture."
>
> Original change's description:
> > Passwords are not available for a page till user gesture.
> > But for usernames it was not implemented. This patch implements
> > this: use SetSuggestedValue for username and register
> > username_element to gatekeeper, which manages revealing
> > the input suggested value to JS after user action.
> >
> > Along the way, a small improvement was implemented, setting
> > the username value only in one place which simplifies the code.
>
> > Bug: 798492
> > Change-Id: Ib37637dd861f44b94674c6d0060ebc91dfd73cff
> > Reviewed-on: https://chromium-review.googlesource.com/850394
> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> > Reviewed-by: Dominic Battré <battre@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#527598}
>
> Original Patch is PatchSet 1.
> Flakiness was fixed on CL https://chromium-review.googlesource.com/c/chromium/src/+/859960
> This CL differs from original only in small compilation fix in PatchSet 5 (compilation
> errors were because of changes in another CL).
>
> TBR=battre@chromium.org
>
> Bug: 798492
> Change-Id: Ife2f67ca2cd75372ef388d077acb9d53b47be92d
> Reviewed-on: https://chromium-review.googlesource.com/854173
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528593}

Flakiness that was a reason of last revert was fixed on
https://chromium-review.googlesource.com/c/chromium/src/+/860649

TBR=battre@chromium.org

Bug: 798492
Change-Id: Ia277559ebe541da25d21f493d0ae2889c676aa9c
Reviewed-on: https://chromium-review.googlesource.com/862143
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528716}
5 files changed
tree: be49c55b50b6a50ca9089fc8d2a55ac00b65bd1c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .