| commit | 3372c29b99475874bb170fba9cd6b56c07aae805 | [log] [tgz] |
|---|---|---|
| author | Sean McAllister <smcallis@google.com> | Fri Oct 30 18:00:24 2020 |
| committer | Sean McAllister <smcallis@google.com> | Fri Oct 30 18:00:24 2020 |
| tree | 49989d59e07e9359cd94ddc42479649ee10d3d7a | |
| parent | 733eb4be553989ffeb63e08d325038dbb539e62f [diff] |
Revert "Reland "[scripts] remove cros_chromite.py"" This reverts commit 14b4b77ce1f93298538f5ce6588358645dbc9048. Reason for revert: This is breaking the chrome-icu package and thus ToT release builders. Original change's description: > Reland "[scripts] remove cros_chromite.py" > > This is a reland of 205b815a8a7d37ed28088f62fb3f4aae99b5c422 > > Internal change is submitted for re-land. > https://crrev.com/i/3366026 > > Original change's description: > > [scripts] remove cros_chromite.py > > > > This was added in > > https://chromium.googlesource.com/chromium/tools/build/+/f25c05905de44825d145543ac5317622e3487e48 > > > > But I think this script is not used now. > > https://source.chromium.org/search?q=cros_chromite.py > > https://source.chromium.org/search?q=cros_chromite_pins > > https://source.chromium.org/search?q=import.*configcache > > > > Let me try to remove and see what happens. > > > > Fixed: 1142424 > > Change-Id: I71b3a4cf7daa671ef6bcb6064c374c6aea9a49db > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2500819 > > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Fixed: 1142424 > Change-Id: I1c81b19251100517ed613c8d2be460e717a3d2ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2505279 > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> TBR=tandrii@google.com,tikuta@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id9cf2cd624be1c6683c99494a25f24b7c0bfd537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2510629 Reviewed-by: Sean McAllister <smcallis@google.com> Commit-Queue: Sean McAllister <smcallis@google.com>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.