Google Git
Sign in
chromium / chromium / src / 3429b21df57fb03c658e5b63ae81a42f4316a978
commit3429b21df57fb03c658e5b63ae81a42f4316a978[log] [tgz]
authorSam McNally <sammc@chromium.org>Fri Dec 07 01:25:24 2018
committerCommit Bot <commit-bot@chromium.org>Fri Dec 07 01:25:24 2018
tree2fcc4c9fc2d1ddd3ae85ea0c54f83ba5c829e93c
parent3fd190dee907661320a5bfc5963d615406fffd35 [diff]
Add ui::SelectFileDialog::FileTypeInfo::ANY_PATH_OR_URL.

For most file select dialogs, hosted docs that can only be accessed via
their URLs are not useful to select. Only browser file-open dialogs can
meaningfully interact with these virtual files, translating their paths
into URLs. Other dialogs return unusable file paths that cannot be
opened as regular files, causing unnecessary and confusing failures.

Add a FileTypeInfo enumerator, ANY_PATH_OR_URL, for clients to opt into
accepting such virtual files, used by Browser. In dialogs not opting
into this mode, disallow selecting hosted docs.

Bug: 843881
Change-Id: I8abc6408e94d60d6e8b3889b0899038c90789119
Reviewed-on: https://chromium-review.googlesource.com/c/1360451
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614556}
15 files changed
tree: 2fcc4c9fc2d1ddd3ae85ea0c54f83ba5c829e93c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .