Google Git
Sign in
chromium / chromium / src / 34683f17ddf749befcc482135f68f397f8809ec0
commit34683f17ddf749befcc482135f68f397f8809ec0[log] [tgz]
authorPavel Yatsuk <pavely@chromium.org>Tue Dec 05 01:43:03 2017
committerCommit Bot <commit-bot@chromium.org>Tue Dec 05 01:43:03 2017
tree7994f3b772e44f97aab374a6006c9fef7ada5d33
parent29d3678b3bdc3d4401596f52f3502b35fed0c685 [diff]
[Sync] Verify that correct value of CookieJarMismatch is passed to SyncCycleContext

SingleClientSessionsSyncTest.CookieJarMismatch test is flaky. It fails on the
step when signed in account gets included in the list of accounts in cookie jar.
In this case value of cookie_jar_mismatch should turn to false.

I wasn't able to reproduce this bug, nor I was able to find scenario how this
test could fail.

I'm adding a check that ensures correct value of cookie_jar_mismatch is passed
to sync engine. The next time this test fails it will be clear if failure caused
by incorrect value or the value wasn't delivered to the server.

R=pnoland@chromium.org
BUG=789129

Change-Id: I508e5d37083e98b2c02e1bf3a35917dad3a9645f
Reviewed-on: https://chromium-review.googlesource.com/804556
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Patrick Noland <pnoland@google.com>
Cr-Commit-Position: refs/heads/master@{#521583}
3 files changed
tree: 7994f3b772e44f97aab374a6006c9fef7ada5d33
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .