| commit | 34aa8228bda00505355d4a9e96a2bcfe23a2b4cb | [log] [tgz] |
|---|---|---|
| author | Jeff Yoon <jeffyoon@google.com> | Wed Nov 04 23:52:53 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 04 23:52:53 2020 |
| tree | d9377a718b5eb873902cfa5972cdbd9d398fb5aa | |
| parent | e812e57c8332e46c452586a66f05b21c30907f5c [diff] |
[ios/webrtc] build command and pass it to Swarming command and relative_cwd properties are being deprecated from isolate and isolated (crbug/1069704). A patch was introduced in crrev/c/2418404 to pass command by fetching what was set in isolated. However, isolated will no longer have the command, so this results in a KeyError. This change builds the command and appends it to the task dict in the isolate_test() method as a workaround with raw_cmd as key. relative_cwd remains defaulted to ".". The SwarmingIosTest object takes raw_cmd and relative_cwd from this dict and passes them when creating the Swarming task object in pre_run. Bug: 1144638 Change-Id: I969e81779880b3b2057f041f427b4614c17fd161 Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2518615 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.