commit | 355a4c84b0d2ea3e6890c0f7ad88c3e91c712f9e | [log] [tgz] |
---|---|---|
author | John Chen <johnchen@chromium.org> | Tue May 29 19:04:16 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue May 29 19:04:16 2018 |
tree | 4a172d89d2a024b048146426bb80fa9e3cf151d7 | |
parent | a4ecd1b1eb90ba7df025a5e15adfdc2ee6cd5dd3 [diff] |
Revert "Reland "[ChromeDriver] Use Browser.close to quit"" This reverts commit 47c575abefd23410eb2b4023a06b171dd3a8b64a. Reason for revert: Causes noticeable slowdown on Windows and some Mac. Reverting for now, and will re-visit after ChromeDriver 2.39 release. Original change's description: > Reland "[ChromeDriver] Use Browser.close to quit" > > This is a reland of 3edba584fc9d669b16f26a6516dc080197144485 > > Original change's description: > > [ChromeDriver] Use Browser.close to quit > > > > Currently, ChromeDriver closes desktop Chrome by simply killing the > > top-level Chrome process. This isn't graceful, and causes problems > > in some scenarios. This commit sends a Browser.close command to close > > the browser gracefully. > > > > Bug: chromedriver:2311 > > Change-Id: Idec9338b094f0aab89022b8453dd2a98268ad1e7 > > Reviewed-on: https://chromium-review.googlesource.com/1037585 > > Commit-Queue: John Chen <johnchen@chromium.org> > > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556689} > > TBR=kereliuk@chromium.org > > Bug: chromedriver:2311 > Change-Id: I302e064532fdadb1b6e40d53fbfe3cf72601a731 > Reviewed-on: https://chromium-review.googlesource.com/1054117 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557613} TBR=johnchen@chromium.org,kereliuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:2311 Change-Id: Iabef56858621949e02e431e9df4a03649572f5da Reviewed-on: https://chromium-review.googlesource.com/1077027 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562535}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .